Cross self attention switch #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
entrpn
commented
Sep 19, 2025
entrpn
commented
- Overrides custom flash block sizes for cross attention to prevent extra padding on small cross attention sequence lengths.
- Same as [WAN] Use different sharding strategy for self and cross attention. #250 but setting the sharding at the NNX module level instead of the splash attention kernel function.
coolkp
previously approved these changes
Sep 22, 2025
Collaborator
Author
|
Just realized that I also need to support ring with these new axis rules. If attention=ring, then force logical axis rules to change in pyconfig such that ring attention is supported. |
coolkp
force-pushed
the
cross_self_attention_switch
branch
13 times, most recently
from
878f045 to
fc17634
Compare
coolkp
force-pushed
the
cross_self_attention_switch
branch
from
fc17634 to
65da062
Compare
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
entrpn
commented
Nov 11, 2025
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
entrpn
commented
Nov 12, 2025
coolkp
previously approved these changes
Nov 12, 2025
coolkp
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.